You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We hit an issue where roman.meta.program.category had a typo where SURVEY -> SURVYEY. This caused downstream problems because roman.meta.program.category is specified in the database as an nvarchar(6), and SURVYEY has 7 characters. We should review the lengths of all of the strings and tend to make them longer than the absolute minimum to fit the one word we know about so far.
Maybe default to ~20 characters for strings where we don't know what to expect.
The text was updated successfully, but these errors were encountered:
@nden , If the possible values are really known and likely to change only rarely, I think enum's are reasonable. But in this case I feel like we just picked a string length that was the length of our default and never looked again? But maybe someone actually knows the values and they are all fewer than 6 characters?
I'm happy to be aggressive about allowing only 'allowed' things when we know what's allowed, but I don't think we should box ourselves in when we don't know what the possibilities are.
We hit an issue where roman.meta.program.category had a typo where SURVEY -> SURVYEY. This caused downstream problems because roman.meta.program.category is specified in the database as an nvarchar(6), and SURVYEY has 7 characters. We should review the lengths of all of the strings and tend to make them longer than the absolute minimum to fit the one word we know about so far.
Maybe default to ~20 characters for strings where we don't know what to expect.
The text was updated successfully, but these errors were encountered: