We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In many locations in the romancal code Step.suffix is set to a seemingly default value for a respective step: https://github.com/search?q=repo%3Aspacetelescope%2Fromancal%20%22suffix%20%3D%22&type=code
Step.suffix
To consider one example, AssignWcsStep sets it's suffix as follows:
AssignWcsStep
romancal/romancal/assign_wcs/assign_wcs_step.py
Lines 48 to 52 in d837289
save_results=True
assignwcs
This could alternatively be handled by setting the suffix in the spec (as is done for several steps in jwst). This has a few benefits:
try/except
Was this a design decision to not use the spec to define the suffix or is using the spec ok?
The text was updated successfully, but these errors were encountered:
suffix
Step.spec
Successfully merging a pull request may close this issue.
In many locations in the romancal code
Step.suffix
is set to a seemingly default value for a respective step:https://github.com/search?q=repo%3Aspacetelescope%2Fromancal%20%22suffix%20%3D%22&type=code
To consider one example,
AssignWcsStep
sets it's suffix as follows:romancal/romancal/assign_wcs/assign_wcs_step.py
Lines 48 to 52 in d837289
To allow files generated by the step (when
save_results=True
, when the suffix is used) to have theassignwcs
suffix.This could alternatively be handled by setting the suffix in the spec (as is done for several steps in jwst). This has a few benefits:
try/except
and other code aboveWas this a design decision to not use the spec to define the suffix or is using the spec ok?
The text was updated successfully, but these errors were encountered: