Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResampleStep.single ignored #1388

Open
braingram opened this issue Aug 27, 2024 · 0 comments
Open

ResampleStep.single ignored #1388

braingram opened this issue Aug 27, 2024 · 0 comments

Comments

@braingram
Copy link
Collaborator

Running resample with --single=True does not run many_to_many:

strun romancal.step.ResampleStep --single=True <some_asn.json>

outputs the appropriate step spec (with single=True)

  single: True

but then calls many_to_one and does not produce an output for each group.

I suggest that we remove this from the spec (rather than changing it to run many_to_many) for the following reasons:

  • many_to_many results are incomplete, they do not contain resampled variance, exposure time, etc
  • a more complete output can be created by generating associations for each group and running them with the default single=False
  • this would allow removal of many_to_many (at the moment this is used by outlier detection but an alternative can be found that produces the same result without requiring use of many_to_many, I'm happy to give more details but this is currently a work-in-progress and isn't the main focus of this issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant