-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rcal-920 script to create associations based on skycells #1437
base: main
Are you sure you want to change the base?
Conversation
e097575
to
851697d
Compare
def passfail(bool_expr): | ||
"""set pass fail""" | ||
if bool_expr: | ||
return "Pass" | ||
return "Fail" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def passfail(bool_expr): | |
"""set pass fail""" | |
if bool_expr: | |
return "Pass" | |
return "Fail" |
No longer needed with the suggestion below: #1437 (comment)
for file in output_files: | ||
skycell_asn.logger.info( | ||
"Check that the json file exists " + passfail(os.path.isfile(file)) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for file in output_files: | |
skycell_asn.logger.info( | |
"Check that the json file exists " + passfail(os.path.isfile(file)) | |
) | |
missing_files = [fn for fn in output_files if not os.path.isfile(fn)] | |
assert not missing_files, f"Missing files: {missing_files}" |
How does this look for an assert
to add to this test? Without an assert that checks there are no missing files the test can silently pass if one or all of the files are missing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 78.38% 78.09% -0.29%
==========================================
Files 118 119 +1
Lines 7680 7744 +64
==========================================
+ Hits 6020 6048 +28
- Misses 1660 1696 +36
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4abb264
to
aaa158b
Compare
for more information, see https://pre-commit.ci
Resolves RCAL-920
Closes #1421
This PR adds code to take an input list of calibrated WFI exposures and creates associations based on the
skycells that they overlap.
Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesRegression test results are at
https://github.com/spacetelescope/RegressionTests/actions/runs/11168259268
news fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.associations.rst
changes/<PR#>.scripts.rst
changes/<PR#>.mosaic_pipeline.rst
changes/<PR#>.patch_match.rst
steps
changes/<PR#>.dq_init.rst
changes/<PR#>.saturation.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.jump_detection.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.assign_wcs.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.photom.rst
changes/<PR#>.flux.rst
changes/<PR#>.source_detection.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.resample.rst
changes/<PR#>.source_catalog.rst