Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outlier detection issues with weight option #1428

Open
braingram opened this issue Oct 1, 2024 · 2 comments
Open

Outlier detection issues with weight option #1428

braingram opened this issue Oct 1, 2024 · 2 comments

Comments

@braingram
Copy link
Collaborator

braingram commented Oct 1, 2024 •
edited
Loading

Outlier detection without resampling uses hard-coded "ivm" weight

romancal/romancal/outlier_detection/outlier_detection.py

Line 96 in b652ef8

weight_type="ivm",

@braingram braingram mentioned this issue Oct 1, 2024
Merged
6 tasks
@braingram
Copy link
Collaborator Author

And related, ResampleData understands wht_type:

romancal/romancal/resample/resample.py

Line 52 in b652ef8

wht_type="ivm",

whereas outlier detection passes in weight_type:

romancal/romancal/outlier_detection/outlier_detection_step.py

Line 108 in b652ef8

"weight_type": self.weight_type,

so "weight_type" is ignored.

@braingram braingram changed the title Outlier detection without resampling uses hard-coded "ivm" weight Outlier detection issues with weight option Oct 1, 2024
@braingram
Copy link
Collaborator Author

@stscijgbot-rstdms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@braingram