Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mosaic skycell regtest #1432

Open
schlafly opened this issue Oct 2, 2024 · 0 comments
Open

Improve mosaic skycell regtest #1432

schlafly opened this issue Oct 2, 2024 · 0 comments

Comments

@schlafly
Copy link
Collaborator

schlafly commented Oct 2, 2024

Brett points out that the mosaic skycell test isn't really testing anything about skycells.
https://github.com/spacetelescope/romancal/blob/main/romancal/regtest/test_mos_pipeline.py#L151-L154

We should consider how we could improve that test. One thing we could check would be if we're populating the relevant skycell name:
https://github.com/spacetelescope/rad/blob/main/src/rad/resources/schemas/mosaic_basic-1.0.0.yaml#L133
which would be at least some indication that we're actually going through the skycell pipeline, but I don't know if we're currently populating that keyword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant