-
Notifications
You must be signed in to change notification settings - Fork 522
Synchronize RADIUSS packages with all local additions #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Synchronize RADIUSS packages with all local additions #2856
Conversation
| cuda_flags.append("-Xcompiler {}".format(using_toolchain[0])) | ||
|
|
||
| # ppc64le workaround | ||
| if spec.satisfies("target=ppc64le %gcc@8.1:"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Sierra being retired, do we need this anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
|
|
||
| if spec.satisfies("+mpi"): | ||
| # MPI configuration from mpi_for_radiuss_projects | ||
| if spec["mpi"].name == "spectrum-mpi" and spec.satisfies("^blt"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't think any spectrum-mpi sections are needed any longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
| sys_type = env["SYS_TYPE"] | ||
|
|
||
| # Replace /usr/bin/srun path with srun flux wrapper path on TOSS 4 | ||
| if "toss_4" in sys_type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed after the update to the CachedCMakePackage that @tdrwenski did?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I think this block can be removed here (and for care, chai, raja-perf, umpire), it looks like the workaround we deleted here for axom: spack/spack#49033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@white238 @tdrwenski thank you for the review !
I am testing your suggested changes in #3067 and in llnl/Caliper#712.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(because I can't apply them here)
No description provided.