Skip to content

Conversation

@davidbeckingsale
Copy link
Contributor

No description provided.

cuda_flags.append("-Xcompiler {}".format(using_toolchain[0]))

# ppc64le workaround
if spec.satisfies("target=ppc64le %gcc@8.1:"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Sierra being retired, do we need this anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.


if spec.satisfies("+mpi"):
# MPI configuration from mpi_for_radiuss_projects
if spec["mpi"].name == "spectrum-mpi" and spec.satisfies("^blt"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't think any spectrum-mpi sections are needed any longer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

sys_type = env["SYS_TYPE"]

# Replace /usr/bin/srun path with srun flux wrapper path on TOSS 4
if "toss_4" in sys_type:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed after the update to the CachedCMakePackage that @tdrwenski did?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think this block can be removed here (and for care, chai, raja-perf, umpire), it looks like the workaround we deleted here for axom: spack/spack#49033

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@white238 @tdrwenski thank you for the review !
I am testing your suggested changes in #3067 and in llnl/Caliper#712.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(because I can't apply them here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants