#712 이용약관 모달에서 개인정보 처리방침 모달 띄울 수 있도록 수정 #721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for taxi-dev-preview failed.
|
14KGun
requested review from
predict-woo,
000wan,
kmc7468,
happycastle114,
SnowSuno and
ybmin
SnowSuno
reviewed
Feb 10, 2024
| @@ -31,35 +32,17 @@ const Mypage = () => { | |||
| const loginInfo = useValueRecoilState("loginInfo"); | |||
| const notificationOptions = useValueRecoilState("notificationOptions"); | |||
| const { id: userId } = loginInfo || {}; | |||
| const { page } = useParams<{ page?: string }>(); | |||
There was a problem hiding this comment.
path param을 직접 가져와서 routing 로직을 아래처럼 직접 작성하는 것보다는 nested route와 <Outlet />을 이용하는게 더 낫지 않을까요?
Comment on lines
+38
to
+40
| const closeModal = useCallback(() => { | ||
| history.push("/mypage"); | ||
| }, []); |
There was a problem hiding this comment.
이부분 useCallback으로 감싸는 것이 필요한가요?
그리고 만약 감싼다면 dependency array에 history도 들어가야 할 듯 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #712
#712 버그를 해결합니다.
마이페이지에서 url 을 통해 이용약관 모달을 띄울 수 있습니다.