Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

예상 택시 비용 보여주기 #762

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

예상 택시 비용 보여주기 #762

wants to merge 11 commits into from

Conversation

ybmin
Copy link
Contributor

@ybmin ybmin commented Mar 13, 2024 •
edited
Loading

Summary

It closes #761

Images or Screenshots

KakaoTalk_20240423_203403324
KakaoTalk_20240423_203412646
KakaoTalk_20240423_203426478 컴포넌트 추가했습니다.

Works to do

  • 방 생성 페이지에서의 컴포넌트 작업 (디자인이 완성되는대로 진행하겠습니다.)

@ybmin ybmin added the ⚒ enhancement New feature or request label Mar 13, 2024
@ybmin ybmin self-assigned this Mar 13, 2024
@ybmin ybmin linked an issue Mar 13, 2024 that may be closed by this pull request
예상 택시 비용 보여주기 컴포넌트 #761
Open
2 tasks
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 08c381f
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/6627a8ca4fd96e00080445ef
😎 Deploy Preview https://deploy-preview-762--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@predict-woo predict-woo marked this pull request as ready for review March 19, 2024 14:24
@ybmin ybmin marked this pull request as draft March 19, 2024 14:26
@ybmin ybmin changed the title 예상 택시 비용 & 예상 엔빵 비용 보여주기 예상 택시 비용 보여주기 Mar 26, 2024
@ybmin
Copy link
Contributor Author

ybmin commented Apr 2, 2024 •
edited
Loading

image

@ybmin
Copy link
Contributor Author

ybmin commented Apr 23, 2024

KakaoTalk_20240423_203403324
KakaoTalk_20240423_203412646
KakaoTalk_20240423_203426478
컴포넌트 추가했습니다.

@ybmin ybmin marked this pull request as ready for review April 23, 2024 12:26
@ybmin ybmin requested review from 14KGun, predict-woo, kmc7468, jinhyeonkwon, jyjy1229 and xMHW and removed request for predict-woo April 23, 2024 12:26
xMHW
xMHW approved these changes Apr 23, 2024
View reviewed changes
Copy link

@xMHW xMHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

predict-woo
predict-woo approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@predict-woo predict-woo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 근데 1000 단위마다 , 를 넣어주면 더 깔끔할 것 같긴 합니다!

@ybmin
Copy link
Contributor Author

ybmin commented Apr 24, 2024

LGTM! 근데 1000 단위마다 , 를 넣어주면 더 깔끔할 것 같긴 합니다!

아래 스크린샷에 나와있듯이, 추가해놓았습니당 (맨 위의 스샷이 오래전꺼라 잘못 나오네요 ㅠㅠ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMHW xMHW xMHW approved these changes

@predict-woo predict-woo predict-woo approved these changes

@14KGun 14KGun Awaiting requested review from 14KGun

@kmc7468 kmc7468 Awaiting requested review from kmc7468

@jinhyeonkwon jinhyeonkwon Awaiting requested review from jinhyeonkwon

@jyjy1229 jyjy1229 Awaiting requested review from jyjy1229

Assignees

@ybmin ybmin

Labels
⚒ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

예상 택시 비용 보여주기 컴포넌트
3 participants
@ybmin @xMHW @predict-woo