Fix support for links starting with #
#725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeier
force-pushed
the
latex-link-to-top
branch
from
335aab5
to
8ea087d
Compare
|
It doesn't look like the Sphinx issues will be fixed soon, so I'll go ahead and merge this work-around. If Sphinx catches up at some point, we can remove this work-around again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems:
#are marked as "external" sphinx-doc/sphinx#11335#doesn't work sphinx-doc/sphinx#11336If those are fixed, this can be closed.
If not, this PR is a work-around that should also fix both problems.
Fixes a part of #530 (links to local files are still marked as "external").
Fixes #664.