Merge pull request #1091 from iamrgroot/fix/context-cloning

fix: clone transformation context instead of creating a new one

Author: rubenvanassche

src/Resolvers/VisibleDataFieldsResolver.php

@@ -38,15 +38,14 @@ public function execute(
             }
 
             if ($next === true) {
-                $fields[$field] = new TransformationContext(
-                    $transformationContext->transformValues,
-                    $transformationContext->mapPropertyNames,
-                    $transformationContext->wrapExecutionType,
-                    $transformationContext->transformers,
-                    depth: $transformationContext->depth + 1,
-                    maxDepth: $transformationContext->maxDepth,
-                    throwWhenMaxDepthReached: $transformationContext->throwWhenMaxDepthReached,
-                );
+                $fieldTransFormationContext = clone $transformationContext;
+                $fieldTransFormationContext->depth++;
+                $fieldTransFormationContext->includePartials = null;
+                $fieldTransFormationContext->excludePartials = null;
+                $fieldTransFormationContext->onlyPartials = null;
+                $fieldTransFormationContext->exceptPartials = null;
+
+                $fields[$field] = $fieldTransFormationContext;
             }
         }
 

tests/Resolvers/VisibleDataFieldsResolverTest.php

@@ -1375,3 +1375,21 @@ public static function instance(bool $includeByDefault): self
         ],
     ]);
 });
+
+it('can handle custom transformation contexts', function () {
+    $data = VisibleFieldsData::instance();
+
+    class CustomTransformationContext extends TransformationContext
+    {
+    };
+
+    $visibleFields = app(VisibleDataFieldsResolver::class)->execute(
+        $data,
+        app(DataConfig::class)->getDataClass($data::class),
+        new CustomTransformationContext(),
+    );
+
+    expect($visibleFields['single'])->toBeInstanceOf(CustomTransformationContext::class);
+    expect($visibleFields['nested'])->toBeInstanceOf(CustomTransformationContext::class);
+    expect($visibleFields['collection'])->toBeInstanceOf(CustomTransformationContext::class);
+});