Merge pull request #139 from stevethomas/main

freekmurze · web-flow · commit 93a6c0bb741d · 2024-05-08T10:00:53.000+02:00
Fix setting the name via download()
diff --git a/src/PdfBuilder.php b/src/PdfBuilder.php
@@ -137,7 +137,7 @@ public function footerHtml(string $html): self
 
     public function download(?string $downloadName = null): self
     {
-        $this->downloadName ?? $this->name($downloadName ?? 'download');
+        $this->downloadName ?: $this->name($downloadName ?? 'download');
 
         $this->addHeaders([
             'Content-Type' => 'application/pdf',

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ public function footerHtml(string $html): self`
`137`	`137`
`138`	`138`	`public function download(?string $downloadName = null): self`
`139`	`139`	`{`
`140`		`- $this->downloadName ?? $this->name($downloadName ?? 'download');`
	`140`	`+ $this->downloadName ?: $this->name($downloadName ?? 'download');`
`141`	`141`
`142`	`142`	`$this->addHeaders([`
`143`	`143`	`'Content-Type' => 'application/pdf',`