Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpng changes over the years #2591

Open
jlovejoy opened this issue Oct 25, 2024 · 6 comments · May be fixed by #2634
Open

libpng changes over the years #2591

jlovejoy opened this issue Oct 25, 2024 · 6 comments · May be fixed by #2634
Assignees
@jlovejoy
Labels
XML markup change potential change or addition to XML markup in license
Milestone
3.26.0

Comments

@jlovejoy
Copy link
Member

jlovejoy commented Oct 25, 2024 •
edited
Loading

see https://gitlab.com/fedora/legal/fedora-license-data/-/issues/296

http://www.libpng.org/pub/png/src/libpng-LICENSE.txt is the URL for both libpng-2.0 and Libpng

the first part/license:

  • is a match to libpng-2.0 (and this is the URL is referenced in the SPDX entry) which was added for version 3.5 in 2019

the second part/license:

BUT over the years, various things were updated such as the list of names and references to version numbers (which would be replaceable by SPDX matching guidelines, but need markup added)
More substantial text changes occurred as well:

libpng-2.0 was added in Nov 2018, which also altered some of the text order, see pnggroup/libpng@e79085a

question is for SPDX now: should these various changes over the years be handled with markup or constitute a new license?
@jlovejoy jlovejoy self-assigned this Oct 25, 2024
@jlovejoy jlovejoy added the XML markup change potential change or addition to XML markup in license label Oct 25, 2024
@jlovejoy jlovejoy added this to the 3.26.0 milestone Oct 25, 2024
@Pizza-Ria
Copy link
Contributor

Looking at the delta view, the most material change is a comment stating "Updated LICENSE to say files in the contrib directory are not necessarily under the libpng license, and that some makefiles have other copyright owners." But that is always true ... one can never assume that a top level license applies to other files in the tree. So, I'm inclined to say there aren't substantive differences in this latest version and it could be handled with markup.

@jlovejoy
Copy link
Member Author

tried to discuss on 12/12 legal call, but my notes above were not sufficient, so will review again and revise

@swinslow
Copy link
Member

@jlovejoy Unless there are particular edits you've got ready now, I'll move this to 3.27.0 and we can aim to tackle it quickly after the 3.26.0 release is out.

@jlovejoy
Copy link
Member Author

jlovejoy commented Dec 16, 2024 •
edited
Loading

adding more thorough time line, starting with:

  1. Dec 2010 - SPDX added https://spdx.org/licenses/Libpng.html for version 1.4 of the SPDX License List (see https://lists.spdx.org/g/spdx/message/236 and discussion prior at https://lists.spdx.org/g/spdx/topic/22079227#msg235 - SPDX added what existed on the URL: http://www.libpng.org/pub/png/src/libpng-LICENSE.txt at that point in time.
  2. Jan 2011 - PNG already had made updates to data and version number, see commit -
  3. July 2015 - consolidated one of the notices and added some names (not substantive)
  4. Feb 2016 - added 2 paragraphs re: "some files have other copyright owners" after list of names. Also removed some text at end re: png logo and added Trademark paragraph. Added Export Control paragraph
  5. July 2018 - updates to export control paragraph.
  6. Nov 2018 - libpng-2.0 added at top, trademark, OSI, and export parts removed

jlovejoy added a commit that referenced this issue Dec 17, 2024
@jlovejoy
Add markup to Libpng.xml
5620ff4 
fixes #2591 

But will also probably need more edits
@jlovejoy jlovejoy linked a pull request Dec 17, 2024 that will close this issue
Open
@jlovejoy
Copy link
Member Author

It was too hard to try to explain in text, so I've made a PR, which is failing and I can't figure out why. I also have a Google doc with comments and color-coding of the various changes over the years.

Overall, there isn't much that has changed substantively, but... mixing acknowledgments in between license text is not optimal for trying to match (and find) the actual license text!

@jlovejoy
Copy link
Member Author

oh, and there is probably more markup needed, but until I can figure out why it's failing, not worth adding more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlovejoy jlovejoy

Labels
XML markup change potential change or addition to XML markup in license
Projects
None yet
Milestone
3.26.0
Development

Successfully merging a pull request may close this issue.

Add markup to Libpng.xml spdx/license-list-XML
3 participants
@swinslow @jlovejoy @Pizza-Ria