Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create --colors-surface-* CSS computed properties to simplify theme overrides #153

Open
psirenny opened this issue Mar 8, 2024 · 0 comments
Open

Create --colors-surface-* CSS computed properties to simplify theme overrides #153

psirenny opened this issue Mar 8, 2024 · 0 comments
Assignees
@psirenny
Labels
🎉 enhancement Enhances the product

Comments

@psirenny
Copy link
Contributor

psirenny commented Mar 8, 2024

The Select and ComboBox components rely on complicated theme overrides to adjust the background color of inputs. Changing the background color is complicated because one must undo the color change for all other possible variations: disabled, invalid, focused, disabled + invalid, and so on.
@psirenny psirenny added the 🎉 enhancement Enhances the product label Mar 8, 2024
@psirenny psirenny self-assigned this Mar 8, 2024
@psirenny psirenny changed the title Create a surface CSS computed property to simplify theme overrides Create --colors-surface-* CSS computed properties to simplify theme overrides Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psirenny psirenny

Labels
🎉 enhancement Enhances the product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psirenny