Skip to content

Commit 0d9fe11

Browse files
committed
switch to firefox for playwright ci tests
1 parent 257dc90 commit 0d9fe11

File tree

4 files changed

+19
-18
lines changed

4 files changed

+19
-18
lines changed

.github/workflows/main.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,12 @@ jobs:
2222
env:
2323
NPM_TOKEN: xxx
2424

25-
- uses: browser-actions/setup-chrome@v1
26-
with:
27-
chrome-version: stable
25+
- uses: browser-actions/setup-firefox@v1
2826

2927
- name: Run all checks
3028
run: xvfb-run pnpm run ci
3129
env:
30+
CI: 1
3231
NPM_TOKEN: xxx
3332

3433
- name: Upload twopoint5d-elements-e2e test-results artifacts

packages/twopoint5d-elements-e2e/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"three": "~0.165.0"
2424
},
2525
"devDependencies": {
26-
"@playwright/test": "^1.38.1",
26+
"@playwright/test": "^1.44.1",
2727
"@types/three": "~0.165.0",
2828
"autoprefixer": "^10.4.19",
2929
"postcss": "^8.4.38",

packages/twopoint5d-elements-e2e/playwright.config.ts

+15-13
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,25 @@ export default defineConfig({
3434

3535
/* Configure projects for major browsers */
3636
projects: [
37-
{
38-
name: 'chromium',
39-
use: {
40-
...devices['Desktop Chrome'],
41-
headless: true,
42-
},
43-
},
44-
4537
{
4638
name: 'firefox',
4739
use: {...devices['Desktop Firefox'], headless: true},
4840
},
4941

50-
{
51-
name: 'webkit',
52-
use: {...devices['Desktop Safari'], headless: true},
53-
},
42+
...(process.env.CI ? [] : [
43+
{
44+
name: 'chromium',
45+
use: {
46+
...devices['Desktop Chrome'],
47+
headless: true,
48+
},
49+
},
50+
{
51+
name: 'webkit',
52+
use: {...devices['Desktop Safari'], headless: true},
53+
},
54+
])
55+
],
5456

5557
/* Test against mobile viewports. */
5658
// {
@@ -71,7 +73,7 @@ export default defineConfig({
7173
// name: 'Google Chrome',
7274
// use: { ...devices['Desktop Chrome'], channel: 'chrome' },
7375
// },
74-
],
76+
// ],
7577

7678
/* Run your local dev server before starting the tests */
7779
webServer: {

pnpm-lock.yaml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)