Skip to content

Commit 2fd3afe

Browse files
spearwolfspearwolf
committed
remove simple-greeting component
1 parent ef6eff3 commit 2fd3afe

File tree

12 files changed

+21
-124
lines changed

12 files changed

+21
-124
lines changed

‎packages/twopoint5d-elements-e2e/index.html

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
<li><a class="hover:underline" href="pages/bundle.html">bundle</a></li>
1313
<li><a class="hover:underline" href="pages/display-and-stage2d.html">display-and-stage2d</a></li>
1414
<li><a class="hover:underline" href="pages/post-processing.html">post-processing</a></li>
15-
<li><a class="hover:underline" href="pages/simple-greeting.html">simple-greeting</a></li>
1615
<li><a class="hover:underline" href="pages/stage2d.html">stage2d</a></li>
1716
<li><a class="hover:underline" href="pages/display.html">display</a></li>
1817
</ul>

‎packages/twopoint5d-elements-e2e/pages/bundle.html

+3-5
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
</head>
99
<body>
1010
<script type="module" src="/src/bundle.ts"></script>
11-
<main>
12-
<simple-greeting debug data-testid="simple-greeting"></simple-greeting>
13-
<two5-display debug data-testid="display"></two5-display>
14-
<two5-texture-store debug data-testid="texture-store"></two5-texture-store>
15-
</main>
11+
<two5-display debug data-testid="display"></two5-display>
12+
<two5-stage2d debug data-testid="stage2d"></two5-stage2d>
13+
<two5-texture-store debug data-testid="texture-store"></two5-texture-store>
1614
</body>
1715
</html>

‎packages/twopoint5d-elements-e2e/pages/simple-greeting.html

-15
This file was deleted.

‎packages/twopoint5d-elements-e2e/src/simple-greeting.ts

-4
This file was deleted.

‎packages/twopoint5d-elements-e2e/tests/bundle.spec.ts

+18-29
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,37 @@
1-
import {expect, test} from '@playwright/test';
1+
import {expect, test, type Page} from '@playwright/test';
2+
3+
const whenDefined = (page: Page, tagName: string) =>
4+
page.evaluate(
5+
(tagName: string) =>
6+
customElements
7+
.whenDefined(tagName)
8+
.then(() => true)
9+
.catch(() => false),
10+
tagName,
11+
);
212

313
test.describe('bundle', () => {
414
test.beforeEach('goto page', async ({page}) => {
515
await page.goto('/pages/bundle.html');
616
});
717

8-
test.describe('simple-greeting', () => {
18+
test.describe('two5-display', () => {
919
test('has element', async ({page}) => {
10-
await expect(page.getByTestId('simple-greeting')).toBeAttached();
20+
await expect(page.getByTestId('display')).toBeAttached();
1121
});
1222

1323
test('custom element is defined', async ({page}) => {
14-
expect(
15-
await page.evaluate(() =>
16-
customElements
17-
.whenDefined('simple-greeting')
18-
.then(() => true)
19-
.catch(() => false),
20-
),
21-
).toBe(true);
24+
expect(await whenDefined(page, 'two5-display')).toBe(true);
2225
});
2326
});
2427

25-
test.describe('two5-display', () => {
28+
test.describe('two5-stage2d', () => {
2629
test('has element', async ({page}) => {
27-
await expect(page.getByTestId('display')).toBeAttached();
30+
await expect(page.getByTestId('stage2d')).toBeAttached();
2831
});
2932

3033
test('custom element is defined', async ({page}) => {
31-
expect(
32-
await page.evaluate(() =>
33-
customElements
34-
.whenDefined('two5-display')
35-
.then(() => true)
36-
.catch(() => false),
37-
),
38-
).toBe(true);
34+
expect(await whenDefined(page, 'two5-stage2d')).toBe(true);
3935
});
4036
});
4137

@@ -45,14 +41,7 @@ test.describe('bundle', () => {
4541
});
4642

4743
test('custom element is defined', async ({page}) => {
48-
expect(
49-
await page.evaluate(() =>
50-
customElements
51-
.whenDefined('two5-texture-store')
52-
.then(() => true)
53-
.catch(() => false),
54-
),
55-
).toBe(true);
44+
expect(await whenDefined(page, 'two5-texture-store')).toBe(true);
5645
});
5746
});
5847
});

‎packages/twopoint5d-elements-e2e/tests/simple-greeting.spec.ts

-22
This file was deleted.

‎packages/twopoint5d-elements/package.json

-6
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@
2525
"default": "./dist/src/events.js",
2626
"types": "./dist/src/events.d.ts"
2727
},
28-
"./simple-greeting.js": {
29-
"default": "./dist/src/simple-greeting.js",
30-
"types": "./dist/src/simple-greeting.d.ts"
31-
},
3228
"./two5-display.js": {
3329
"default": "./dist/src/two5-display.js",
3430
"types": "./dist/src/two5-display.d.ts"
@@ -43,12 +39,10 @@
4339
}
4440
},
4541
"sideEffects": [
46-
"build/src/simple-greeting.js",
4742
"build/src/two5-display.js",
4843
"build/src/two5-stage2d.js",
4944
"build/src/two5-texture-store.js",
5045
"build/src/components/attachContextRoot.js",
51-
"dist/src/simple-greeting.js",
5246
"dist/src/two5-display.js",
5347
"dist/src/two5-stage2d.js",
5448
"dist/src/two5-texture-store.js",

‎packages/twopoint5d-elements/package.override.json

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"sideEffects": [
33
"bundle.js",
44
"src/bundle.js",
5-
"src/simple-greeting.js",
65
"src/two5-display.js",
76
"src/two5-stage2d.js",
87
"src/two5-texture-store.js",

‎packages/twopoint5d-elements/src/bundle.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import './simple-greeting.js';
21
import './two5-display.js';
32
import './two5-stage2d.js';
43
import './two5-texture-store.js';

‎packages/twopoint5d-elements/src/components/SimpleGreeting.ts

-36
This file was deleted.

‎packages/twopoint5d-elements/src/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
export * from './components/DisplayElement.js';
2-
export * from './components/SimpleGreeting.js';
32
export * from './components/Stage2DElement.js';
43
export * from './components/TextureStoreElement.js';
54
export * from './components/TwoPoint5DElement.js';

‎packages/twopoint5d-elements/src/simple-greeting.ts

-3
This file was deleted.

0 commit comments

Comments
 (0)