Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revit: cutback parameters not set for framing on receive #3121

Open
5 tasks done
dtnaughton opened this issue Jan 3, 2024 · 1 comment
Open
5 tasks done

revit: cutback parameters not set for framing on receive #3121

dtnaughton opened this issue Jan 3, 2024 · 1 comment
Labels
backlog Raised on the CNX backlog bug Something isn't working

Comments

@dtnaughton
Copy link
Contributor

dtnaughton commented Jan 3, 2024

Prerequisites

What package are you referring to?

speckle-sharp (revit)

Describe the bug

  • START_JOIN_CUTBACK and END_JOIN_CUTBACK parameters are not being set on receive into Revit for framing.

To Reproduce

  1. Send beam (with valid values for cutback parameters) and columns to Speckle - note the START_JOIN_CUTBACK and END_JOIN_CUTBACK parameters do get sent
  2. Receive objects into a new model, noting that cutback parameters get set to default values (0mm for beams and 12.7mm for bracing iirc).

Expected behavior

Cutback parameter values should be set.

Screenshots

System Info

If applicable, please fill in the below details - they help a lot!

Desktop (please complete the following information):

  • OS: Windows 10

Failure Logs

Additional context

I did some extra scoping of the issue and thought I'd share what insight I have:

  • The parameters on the beam that is created (fetched here) has parameters matching those created for a beam that is set to disallow joins, i.e. missing the START_JOIN_CUTBACK and END_JOIN_CUTBACK parameters (plus two others not relevant to this issue).
  • My initial thought was that applying allow join is done somewhere later in the operation and therefore the parameter is not yet accessible on the element during the conversion method.
  • However, I can access/set the cutback parameters on the object explicitly in the conversion method utilizing TrySetParam on the explicit parameter BuiltInParameter.START_JOIN_CUTBACK.

Proposed Solution (if any)

  • Simple fix would just be to try setting these parameters on the beam/brace conversion methods separate to the parameters that are set in the Utils method. I added a quickfix to Arup's repo for this to support a project workflow in the interim to a more robust solution.
  • Alternatively a better understanding of why these parameters don't surface in the Utils method.

Optional: Affected Projects

@dtnaughton dtnaughton added the bug Something isn't working label Jan 3, 2024
@jsdbroughton
Copy link
Contributor

@jsdbroughton jsdbroughton added the backlog Raised on the CNX backlog label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Raised on the CNX backlog bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants