From 93bb2caaac53f397d591d4847c73ca5e01fc2bd1 Mon Sep 17 00:00:00 2001
From: Tim Ling <791016+kettlebell@users.noreply.github.com>
Date: Tue, 22 Nov 2022 00:40:35 +1100
Subject: [PATCH] Remove `unwrap` in `NetworkController::poll`

---
 spectrum-network/src/network_controller.rs | 43 ++++++++++++++--------
 1 file changed, 28 insertions(+), 15 deletions(-)

diff --git a/spectrum-network/src/network_controller.rs b/spectrum-network/src/network_controller.rs
index c66c5175..7057cd34 100644
--- a/spectrum-network/src/network_controller.rs
+++ b/spectrum-network/src/network_controller.rs
@@ -114,7 +114,9 @@ pub struct NetworkController<TPeers, TPeerManager, THandler> {
     peer_manager: TPeerManager,
     enabled_peers: HashMap<PeerId, ConnectedPeer<THandler>>,
     requests_recv: UnboundedReceiver<NetworkControllerIn>,
-    pending_actions: VecDeque<NetworkBehaviourAction<NetworkControllerOut, PartialPeerConnHandler>>,
+    pending_actions: VecDeque<
+        NetworkBehaviourAction<Result<NetworkControllerOut, NetworkControllerError>, PartialPeerConnHandler>,
+    >,
 }
 
 impl<TPeers, TPeerManager, THandler> NetworkController<TPeers, TPeerManager, THandler>
@@ -158,7 +160,7 @@ where
     THandler: ProtocolEvents + Clone + 'static,
 {
     type ConnectionHandler = PartialPeerConnHandler;
-    type OutEvent = NetworkControllerOut;
+    type OutEvent = Result<NetworkControllerOut, NetworkControllerError>;
 
     fn new_handler(&mut self) -> Self::ConnectionHandler {
         trace!("New handler is created");
@@ -443,20 +445,25 @@ where
                                 ConnectedPeer::Connected {
                                     enabled_protocols, ..
                                 } => {
-                                    let (_, prot_handler) = self.supported_protocols.get(&protocol).unwrap();
-                                    match enabled_protocols.entry(protocol) {
-                                        Entry::Occupied(_) => warn!(
-                                            "PM requested already enabled protocol {:?} with peer {:?}",
-                                            protocol, pid
-                                        ),
-                                        Entry::Vacant(protocol_entry) => {
-                                            protocol_entry.insert((
-                                                EnabledProtocol::PendingEnable,
-                                                prot_handler.clone(),
-                                            ));
-                                            prot_handler.protocol_requested_local(pid);
+                                    if let Some((_, prot_handler)) = self.supported_protocols.get(&protocol) {
+                                        match enabled_protocols.entry(protocol) {
+                                            Entry::Occupied(_) => warn!(
+                                                "PM requested already enabled protocol {:?} with peer {:?}",
+                                                protocol, pid
+                                            ),
+                                            Entry::Vacant(protocol_entry) => {
+                                                protocol_entry.insert((
+                                                    EnabledProtocol::PendingEnable,
+                                                    prot_handler.clone(),
+                                                ));
+                                                prot_handler.protocol_requested_local(pid);
+                                            }
                                         }
-                                    };
+                                    } else {
+                                        return Poll::Ready(NetworkBehaviourAction::GenerateEvent(Err(
+                                            NetworkControllerError::UnsupportedProtocol(protocol),
+                                        )));
+                                    }
                                 }
                                 ConnectedPeer::PendingConnect
                                 | ConnectedPeer::PendingApprove(_)
@@ -548,3 +555,9 @@ where
         }
     }
 }
+
+#[derive(Debug, thiserror::Error)]
+pub enum NetworkControllerError {
+    #[error("Unsupported protocol: {0:?}")]
+    UnsupportedProtocol(ProtocolId),
+}