Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GOMAXPROCS and GOMEMLIMIT #650

Open
phillebaba opened this issue Nov 27, 2024 · 0 comments
Open

Set GOMAXPROCS and GOMEMLIMIT #650

phillebaba opened this issue Nov 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@phillebaba
Copy link
Member

phillebaba commented Nov 27, 2024

Describe the problem to be solved

Currently we do not set GOMAXPROCS and GOMEMLIMIT which means that the defaults will be used based on the host machine and not the container resources. This can have repercussions like CPU throttling due to Spegel using more CPU than was actually allocated.

Proposed solution to the problem

Good example for how to set this in the Helm chart based on resource limits.

https://gitlab.com/gitlab-org/charts/gitlab-agent/-/merge_requests/104

Another blog post with an example.

https://metoro.io/blog/go-production-performance-gotcha-gomaxprocs

We should use the benchmarks to measure the performance to see if there is any difference when configuring these values.

@phillebaba phillebaba added the enhancement New feature or request label Nov 27, 2024
@phillebaba phillebaba moved this to Todo in Roadmap Dec 17, 2024
@phillebaba phillebaba removed this from Roadmap Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant