Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we attempt to validate the private key on a load? #16

Open
sfluhrer opened this issue May 10, 2021 · 1 comment
Open

Should we attempt to validate the private key on a load? #16

sfluhrer opened this issue May 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@sfluhrer
Copy link
Collaborator

The private key consists of 4 values; one is the 'hypertree root' which is a function of two of the others.

This suggestion would be, when we attempt to load a private key, we would recompute what the hypertree root ought to be, and error out if it's not what we expect.

The point of this would be to catch it if we load a private key into the wrong class; e.g. load a 128f private key key into a 128s key type.

@sfluhrer sfluhrer added the enhancement New feature or request label May 10, 2021
@sfluhrer
Copy link
Collaborator Author

The pk-validate branch has the appropriate changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant