fix: Add "skip to main content" a11y feature #12408
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjsewell
requested changes
Jun 4, 2024
kaycebasques
commented
Jun 24, 2024
| # html_css_files = [ | ||
| # # 'basic.css', # included through inheritance from the basic theme | ||
| # 'sphinx13.css', | ||
| # ] |
There was a problem hiding this comment.
This is just my WIP code to apply the changes to upstream Sphinx docs. None of this should be merged.
kaycebasques
commented
Jun 24, 2024
| left: -1000%; | ||
| background-color: #fda; | ||
| padding: 1em; | ||
| } |
There was a problem hiding this comment.
new node will render like this. I used the same background that system-message uses. LMK if the background should be something else.
|
Hi @chrisjsewell picking this back up. I addressed your first round of comments. LMK if you want to proceed with this and I will add the same a11y fix/feature to all the other builtin themes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Improve usability of core Sphinx themes for people who rely on
Tab-based navigationFeature or Bugfix
Purpose
Relates