Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Settings dialog #465

Closed
theRealPadster opened this issue Mar 21, 2023 · 4 comments · Fixed by #468 or #792
Closed

Redesign Settings dialog #465

theRealPadster opened this issue Mar 21, 2023 · 4 comments · Fixed by #468 or #792
Labels
💫 enhancement New feature or request ⛑ help wanted Extra attention is needed 📨 proposed

Comments

@theRealPadster
Copy link
Member

theRealPadster commented Mar 21, 2023

📝 Provide a description of the new feature

  • It's super tall and scrolls, which may cause people to not notice there is more than what's initially visible
  • The tabs being controlled by toggles and up/down arrows is a weird not particularly intuitive design pattern
  • It just doesn't look great
  • We could also add the Marketplace version somewhere in here

➕ Additional Information

Current implementation (too tall and scrolls on most screens)
image

Proposed edit to tabs:
What if we make the tabs drag and drop, and click to toggle? We can grey them out or add an outline for enabled ones or something.
image

We could also use an accordion for the sections. e.g. "Options" starts collapsed, but you can click it and it expands to show the settings you can toggle.

@theRealPadster theRealPadster added 💫 enhancement New feature or request ⛑ help wanted Extra attention is needed 📨 proposed labels Mar 21, 2023
@theRealPadster theRealPadster linked a pull request Mar 26, 2023 that will close this issue
@theRealPadster
Copy link
Member Author

Alternatively, we could do something like Finder's toolbar customization (I believe Firefox has similar functionality for its toolbar). We would two sections, one with inactive tabs and one with active tabs, and you can drag and drop them around to order or remove.

image

@theRealPadster
Copy link
Member Author

I don't think this was meant to be closed with the commit that cleaned it up a bit. It still could be much better and not all of the things here have been addressed.

@zhngharry
Copy link
Contributor

I can work on this, is this still open?

@theRealPadster
Copy link
Member Author

I can work on this, is this still open?

I think it could still look a bit better, so sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💫 enhancement New feature or request ⛑ help wanted Extra attention is needed 📨 proposed
Projects
None yet
2 participants