Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status conditions to Shim status #45

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tillknuesting
Copy link

@tillknuesting tillknuesting commented Mar 15, 2024

Describe your changes

Implement status conditions in Shim status to reflect readiness based on node provisioning status. #51

Issue ticket number and link

// TODO: include proper status conditions to update

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@tillknuesting tillknuesting changed the title refactor(status): optimize shim status update logic Add status conditions to Shim status Mar 15, 2024
@tillknuesting
Copy link
Author

@voigt @0xE282B0, Could you give feedback on whether this PR meets the intention expressed in the TODO?

@0xE282B0 0xE282B0 self-assigned this Mar 15, 2024
@0xE282B0
Copy link
Contributor

Hey @tillknuesting,
Awesome that you are contributing!
We're currently on a conference marathon, but we'll have a look later 😁

@phyrog phyrog linked an issue Mar 19, 2024 that may be closed by this pull request
@voigt
Copy link
Contributor

voigt commented Apr 2, 2024

Hey @tillknuesting,
Thank you for the PR and tackling the issue.

Apart from the implementation, a significant part of the issue is investigating the different possible states and under which conditions they occur. IMO, there are at least three states:

  • ready (...)
  • pending (jobs are scheduled/running; not all finished)
  • failed (at least one job wasn't successful / got stuck?)

Other states may be reasonable as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Shim Status information to .shim.status
5 participants