Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Non-HTTP Triggers #15

Open
calebschoepp opened this issue Feb 2, 2024 · 5 comments
Open

Support for Non-HTTP Triggers #15

calebschoepp opened this issue Feb 2, 2024 · 5 comments

Comments

@calebschoepp
Copy link
Contributor

One thing that would be incredibly value in a kubernetes deployment is the ability to use alternative triggers - this is currently blocked on deislabs/containerd-wasm-shims#193 - but we should run through a hypothetical example to understand if we're over-optimizing our api surface towards http.

@calebschoepp
Copy link
Contributor Author

Previous Discussion

@calebschoepp

Redis trigger is already supported and I tested it.

@radu-matei

ref deislabs/containerd-wasm-shims#193

@bacongobbler
Copy link
Contributor

I'm assuming this is in the "nice to have" category for the initial release. Please correct me if I'm wrong.

@radu-matei
Copy link
Member

Is this an issue we can close now?

@calebschoepp
Copy link
Contributor Author

I don't think we can close this yet. AFAIK we don't support arbitrary triggers in the shim which is what this is tracking.

If we no longer care about that or want to track that in the shim repo then those would be good reasons to close this issue.

@endocrimes
Copy link
Contributor

We have a bit of work to do in the operator to potentially configure supported triggers (the shim automatically picking things up from the artifact rocks) but do we want to reason through things like "custom http ports"? Or health checks for non http triggers? etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants