Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CI #18

Open
suneetnangia opened this issue Mar 19, 2024 · 6 comments
Open

Introduce CI #18

suneetnangia opened this issue Mar 19, 2024 · 6 comments

Comments

@suneetnangia
Copy link
Collaborator

CI with following:

  1. PR checks for linting, builds, tests
  2. Main merge: building and releasing trigger as release artefacts in GH along with respective manifests.
  3. Possibly multi arch builds/releases
@suneetnangia
Copy link
Collaborator Author

CI currently fails... not a blocker atm, I'll have a look as well.
CC: @karthik2804.

@karthik2804
Copy link
Contributor

karthik2804 commented Mar 29, 2024

A fix for that is in progress. The pluginify binary is built on Ubuntu 22.04 which has been known to cause issue running on older Ubuntu/Debian. There is a open PR there to address it. Should have a new release early next week.

The test run I did was on Ubuntu-22.04 then switched to 20.04 to avoid the same issues with this plugin.

@karthik2804
Copy link
Contributor

A new release of pluginify is out and CI should work now if re-triggered. If it still fails, I will investigate.

@suneetnangia
Copy link
Collaborator Author

suneetnangia commented Apr 12, 2024

Will keep an eye on it, thanks @karthik2804

@mikkelhegn
Copy link

Currently no MacOS/aarch64 plugin is available in the repo. Is the plan with this issue to include that?

@karthik2804
Copy link
Contributor

karthik2804 commented Apr 15, 2024

@mikkelhegn - The binaries should start to publish once the CI runs both in canary and versioned builds.
@suneetnangia on that note, can we trigger a re run of the CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants