Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement bagging #160

Open
stonier opened this issue Jun 6, 2020 · 0 comments
Open

Re-implement bagging #160

stonier opened this issue Jun 6, 2020 · 0 comments

Comments

@stonier
Copy link
Member

stonier commented Jun 6, 2020

This was available in ROS1 (albeit without too much flexibility for different use cases), but removed in ROS2 since rosbags were not yet available. Trees could alternatively be bagged by usual mechanisms, however it's still useful to be able to do this in-tree:

  1. more efficient: direct bagging vs streaming + bagging
  2. conditionally bag: open/close a bag every time a task is started/completed

Some thoughts on implementation:

  • Exemplar: should aim to be inspirational rather than trying to satisfy every use case
  • Decouple: don't build it into the tree, perhaps a post tick handler
  • Building Blocks - provide building blocks that users can sub-class or stitch together easily so they don't have to do it from scratch
  • PyTrees ROS Tutorial - add another tutorial

See also #159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant