Add flag denoting first sync response #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildbyte
approved these changes
Aug 7, 2024
| @@ -47,6 +48,8 @@ pub(super) struct SeafowlFlightHandler { | |||
| pub context: Arc<SeafowlContext>, | |||
| pub results: Arc<DashMap<String, Mutex<SendableRecordBatchStream>>>, | |||
| sync_writer: Arc<RwLock<SeafowlDataSyncWriter>>, | |||
| // Denotes whether we're past the first sync reponse, thus indicating Seafowl (re)starts | |||
| first_sync: Arc<AtomicBool>, | |||
There was a problem hiding this comment.
This doesn't need to be tracked for each origin separately?
There was a problem hiding this comment.
My understanding was no, only the overall response order is important, cc @eatonphil?
Co-authored-by: Artjoms Iskovs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is tracked in
SeafowlFlightHandlersince it is the one that actually constructs the response (notSeafowlDataSyncWriter), and in addition it has short-circuiting for the "probing" request.Also enable
IF (NOT) EXISTSshort-circuiting for table creation/dropping, so it also closes #589.