Skip to content

Commit f2ba058

Browse files
fix: add proper log message when argo logs yields with EOF error (#34)
This PR provides proper log message when the EOF error appears while performing argo logs --follow operation. It caused a lot of confusion among developers, since it looked like the tests stopped being performed (although they were still in progress). The developers used to unnecessarily re-trigger tests in this case. The message should be enough. Optionally, we could also add one or two retries of argo logs --follow while getting EOF error (https://grpc.github.io/grpc/core/md_doc_statuscodes.html)
1 parent 13162a5 commit f2ba058

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ outputs:
8080
description: 'Name of workflow triggered'
8181
runs:
8282
using: 'docker'
83-
image: 'docker://ghcr.io/splunk/wfe-test-runner-action/wfe-test-runner-action:v5.0.1'
83+
image: 'Dockerfile'
8484
args:
8585
- ${{ inputs.workflow-tmpl-name }}
8686
- ${{ inputs.workflow-template-ns }}

entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,4 @@ echo "After argo submit $?"
4747
echo 'WORKFLOW_NAME:' ${WORKFLOW_NAME}
4848
echo "workflow-name=$(echo $WORKFLOW_NAME)" >> $GITHUB_OUTPUT
4949

50-
argo logs --follow ${WORKFLOW_NAME} -n ${2}
50+
argo logs --follow ${WORKFLOW_NAME} -n ${2} || echo "... There was an error fetching the logs. The workflow is still in progress, and the tests are still running. The results will be available in the Test Report step. Please wait for the workflow to complete. ..."

0 commit comments

Comments
 (0)