Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session files in web UI arent deleted on shutdown #2272

Open
Mai-19 opened this issue Jan 1, 2025 · 0 comments
Open

Session files in web UI arent deleted on shutdown #2272

Mai-19 opened this issue Jan 1, 2025 · 0 comments
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed Web UI Issues or PRs relating to the Web UI

Comments

@Mai-19
Copy link

Mai-19 commented Jan 1, 2025

System OS

Linux

Python Version

3.10 (CPython)

Install Source

pip / PyPi

Install version / commit hash

v4.2.10

Expected Behavior vs Actual Behavior

What should happen: On closing of server, session files holding temporary copies of the songs should have been deleted
What did happen: Nothing, the shutdown event isnt being run at all

i tried changing it to use lifespan instead of the on_event method and it still had the same issue

Steps to reproduce - Ensure to include actual links!

run: spotdl web
download anything
close the tab

Traceback

Using cached web app. To update use the `--force-update-gui` flag.              
Files are stored in temporary directory and will be deleted after the program   
exits to save them to current directory permanently enable the                  
`web_use_output_dir` option                                                     
Starting web server                                                             
                                                                                
INFO:     Started server process [72268]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://localhost:8800 (Press CTRL+C to quit)
INFO:     127.0.0.1:59348 - "GET / HTTP/1.1" 200 OK
INFO:     127.0.0.1:59348 - "GET /assets/index-CqL-qAH-.js HTTP/1.1" 200 OK
INFO:     127.0.0.1:59362 - "GET /assets/index-DRB2_ZPb.css HTTP/1.1" 200 OK
INFO:     ('127.0.0.1', 59378) - "WebSocket /api/ws?client_id=ff2ff1cd-e34d-4696-a51f-ca8e72f243f3" [accepted]
INFO:     Client ff2ff1cd-e34d-4696-a51f-ca8e72f243f3 connected
INFO:     connection open
INFO:     127.0.0.1:59348 - "GET /api/version HTTP/1.1" 200 OK
INFO:     127.0.0.1:59362 - "GET /api/settings?client_id=ff2ff1cd-e34d-4696-a51f-ca8e72f243f3 HTTP/1.1" 200 OK
INFO:     127.0.0.1:56102 - "GET /api/songs/search?query=modern+baseball HTTP/1.1" 200 OK
Modern Baseball - Your Graduation: Downloading                                  
Modern Baseball - Your Graduation: Embedding metadata                           
Modern Baseball - Your Graduation: Done                                         
1/0 complete                                                                    
Downloaded "Modern Baseball - Your Graduation":                                 
https://music.youtube.com/watch?v=NnI6OyJtxQw                                   
INFO:     127.0.0.1:56102 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F7kVoPBSlGghzLoQjODkxGD&client_id=ff2ff1cd-e34d-4696-a51f-ca8e72f243f3 HTTP/1.1" 200 OK
INFO:     127.0.0.1:56102 - "GET /api/download/file?file=%2Fhome%2Fmai%2F.spotdl%2Fweb%2Fsessions%2Fff2ff1cd-e34d-4696-a51f-ca8e72f243f3%2FModern%20Baseball%20-%20Your%20Graduation.mp3&client_id=ff2ff1cd-e34d-4696-a51f-ca8e72f243f3 HTTP/1.1" 200 OK
INFO:     connection closed
INFO:     Shutting down server, no active connections
INFO:     Shutting down
INFO:     Shutting down
INFO:     Finished server process [72268]

Other details

No response

@Mai-19 Mai-19 added the Bug Unexpected problem or unintended behavior that needs to be fixed label Jan 1, 2025
@Silverarmor Silverarmor added the Web UI Issues or PRs relating to the Web UI label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed Web UI Issues or PRs relating to the Web UI
Projects
None yet
Development

No branches or pull requests

2 participants