Default-value fields missing on server

[dawadam]

Hello,

We noticed an issue with ProtoOANewOrderReq messages:

Fields like orderType and tradeSide have valid values on the client side.

Encoding via ts-proto correctly follows Proto2: fields set to their default values are not sent.

Decoding locally shows all expected values, including defaults.

Problem:
The server does not receive fields whose value matches the default and rejects the request. It seems the server does not handle Proto2 default values properly.

Steps to reproduce:

Create ProtoOANewOrderReq with orderType = MARKET and tradeSide = BUY.

Encode with ts-proto.

Send to the server.

Observe that orderType and tradeSide are missing server-side.

Expected:
Server should accept messages even when some fields are set to their default values, as per Proto2 specification.

Thanks!

[dawadam]

The root cause is that ts-proto treats the first enum value (=0) as the default for Proto2. Currently, MARKET = 1 (for ProtoOAOrderType) and BUY = 1 (for ProtoOATradeSide) are non-zero, but ts-proto still omits them because the default handling conflicts with the implicit Proto2 behavior.

To fix this, define an explicit zero value for each enum as the default “unspecified” value:

enum ProtoOATradeSide {
    TRADE_SIDE_UNSPECIFIED = 0;
    BUY = 1;
    SELL = 2;
}

enum ProtoOAOrderType {
    ORDER_TYPE_UNSPECIFIED = 0;
    MARKET = 1;
    LIMIT = 2;
    STOP = 3;
    STOP_LOSS_TAKE_PROFIT = 4;
    MARKET_RANGE = 5;
    STOP_LIMIT = 6;
}

Now, valid values (MARKET = 1, BUY = 1) are not treated as default, and ts-proto will always serialize them, ensuring the server receives the fields correctly.