Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CommentParser eol issue #184 #185

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix CommentParser eol issue #184 #185

wants to merge 1 commit into from

Conversation

moh-hassan
Copy link

@moh-hassan moh-hassan commented Dec 14, 2021 •
edited
Loading

Fix #184 NewLine in CommentParser for Linux/Windows Environment.
Also, the PR fix a fail of test case when running the test project in Linux (Ubuntu 18.04)

Sprache.Tests.Scenarios.AssemblerTests.CanParseSeceralLines [FAIL]
  Failed Sprache.Tests.Scenarios.AssemblerTests.CanParseSeceralLines [3 ms]
  Error Message:
   Assert.Equal() Failure

@nblumhardt
Copy link
Member

Hi! Thanks for this. Looks like the problem is actually in the constructor, line 36? (The newline style there is at odds with the comment). I think a permissive scheme of handling any new-line char would work best here though 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test for testing single comment generated by CommentParser class pass in linux and fail in windows
2 participants
@moh-hassan @nblumhardt