-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume pricing for product total #45
Comments
It doesn't seem like madness to me and makes sense. I think a short way to say what you said above would be:
I think seeing this implemented in code would allow me to grasp it better. |
@radar you've got it! Thanks for the tl;dr version of my brain dump. |
Did you get anywhere with that @createdbypete? I'm looking for just that! |
@egbert no sorry shortly after I was pulled onto another project and never revisited (and forgot about it). |
@egbert or @createdbypete, are you still in search of this functionality? I believe it would probably need to have a configuration option, as not every store is going to want this sort of behavior. |
I actually implemented this, but I'm not really confident to release it as there are quite a few quirks you have to take into account if you decide to use it. |
@egbert if you would like you can submit a PR to If you do submit a PR please make sure you rebase. |
Something that has come up before with volume pricing is being able to have it applied to the whole product. An example should make this easier to understand.
In the example above you may wish to apply the volume price for each variant based on the total number of products not just the quantity of the individual variant.
So perhaps in the product there is an option to indicate total product quantity volume pricing (total of all variants in cart) or keep the current per variant volume pricing (total per variant).
Hopefully that make sense! My initial thoughts are to use the line items to find the other variants of the same product, sum the line item quantities together and pass that through to the volume price finder for each line item.
Open to the floor for feedback in case this is all complete madness.
The text was updated successfully, but these errors were encountered: