Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume pricing for product total #45

Open
createdbypete opened this issue Nov 14, 2013 · 7 comments
Open

Volume pricing for product total #45

createdbypete opened this issue Nov 14, 2013 · 7 comments

Comments

@createdbypete
Copy link

Something that has come up before with volume pricing is being able to have it applied to the whole product. An example should make this easier to understand.

You supply uniforms they are often purchased by groups when new recruits join, this can often happen in batches. The group maybe ordering 10 t-shirts but they would be in various sizes. 3 Small, 6 Medium and 1 Large for example. Your volume pricing starts at 10 items per variant but it is unlikely your customers would ever purchase so many of a single size but combining all the sizes in the basket would often qualify.

In the example above you may wish to apply the volume price for each variant based on the total number of products not just the quantity of the individual variant.

So perhaps in the product there is an option to indicate total product quantity volume pricing (total of all variants in cart) or keep the current per variant volume pricing (total per variant).

Hopefully that make sense! My initial thoughts are to use the line items to find the other variants of the same product, sum the line item quantities together and pass that through to the volume price finder for each line item.

Open to the floor for feedback in case this is all complete madness.

@radar
Copy link

radar commented Nov 20, 2013

It doesn't seem like madness to me and makes sense. I think a short way to say what you said above would be:

Buying several variants of a product should entitle people to bulk discounts for that single product.

I think seeing this implemented in code would allow me to grasp it better.

@createdbypete
Copy link
Author

createdbypete commented Nov 20, 2013

@radar you've got it! Thanks for the tl;dr version of my brain dump.

@egbert
Copy link

egbert commented Jan 11, 2015

Did you get anywhere with that @createdbypete? I'm looking for just that!

@createdbypete
Copy link
Author

@egbert no sorry shortly after I was pulled onto another project and never revisited (and forgot about it).

@jspizziri
Copy link
Member

@egbert or @createdbypete, are you still in search of this functionality?

I believe it would probably need to have a configuration option, as not every store is going to want this sort of behavior.

@egbert
Copy link

egbert commented Jul 17, 2015

I actually implemented this, but I'm not really confident to release it as there are quite a few quirks you have to take into account if you decide to use it.

@jspizziri
Copy link
Member

@egbert if you would like you can submit a PR to master and I can take a look at it. We can discuss the quirks and see if it's something we want to merge in. We recently added the ability to add a volume_price to the master variant and apply those same prices to all variants. However what it does not do is sum all the variant quantities together and apply a price based on that, but I could potentially see a road to success there.

If you do submit a PR please make sure you rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants