Skip to content

Commit 946299b

Browse files
committed
Rename BaseServerFactoryPropertyMapper to DefaultServerFactoryPropertyMapper
1 parent 42cdd2f commit 946299b

File tree

4 files changed

+19
-12
lines changed

4 files changed

+19
-12
lines changed
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,25 @@
2424
import io.grpc.ServerBuilder;
2525

2626
import org.springframework.boot.context.properties.PropertyMapper;
27+
import org.springframework.grpc.server.DefaultGrpcServerFactory;
2728

2829
/**
29-
* Helper class used to map {@link GrpcServerProperties} to various {@link ServerBuilder}.
30+
* Helper class used to map {@link GrpcServerProperties} to
31+
* {@link DefaultGrpcServerFactory}.
3032
*
3133
* @author Chris Bono
3234
* @param <T> the type of server builder
3335
*/
34-
class BaseServerFactoryPropertyMapper<T extends ServerBuilder<T>> {
36+
class DefaultServerFactoryPropertyMapper<T extends ServerBuilder<T>> {
3537

3638
final GrpcServerProperties properties;
3739

38-
BaseServerFactoryPropertyMapper(GrpcServerProperties properties) {
40+
DefaultServerFactoryPropertyMapper(GrpcServerProperties properties) {
3941
this.properties = properties;
4042
}
4143

4244
/**
43-
* Maps the properties to the server builder.
45+
* Map the properties to the server factory's server builder.
4446
* @param serverBuilder the builder
4547
*/
4648
void customizeServerBuilder(T serverBuilder) {

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/NettyServerFactoryPropertyMapper.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,15 @@
1818

1919
import io.grpc.netty.NettyServerBuilder;
2020

21+
import org.springframework.grpc.server.NettyGrpcServerFactory;
22+
2123
/**
22-
* Helper class used to map {@link GrpcServerProperties} to {@link NettyServerBuilder}.
24+
* Helper class used to map {@link GrpcServerProperties} to
25+
* {@link NettyGrpcServerFactory}.
2326
*
2427
* @author Chris Bono
2528
*/
26-
class NettyServerFactoryPropertyMapper extends BaseServerFactoryPropertyMapper<NettyServerBuilder> {
29+
class NettyServerFactoryPropertyMapper extends DefaultServerFactoryPropertyMapper<NettyServerBuilder> {
2730

2831
NettyServerFactoryPropertyMapper(GrpcServerProperties properties) {
2932
super(properties);

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/ShadedNettyServerFactoryPropertyMapper.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@
1818

1919
import io.grpc.netty.shaded.io.grpc.netty.NettyServerBuilder;
2020

21+
import org.springframework.grpc.server.ShadedNettyGrpcServerFactory;
22+
2123
/**
22-
* Helper class used to map {@link GrpcServerProperties} to the shaded
23-
* {@link NettyServerBuilder}.
24+
* Helper class used to map {@link GrpcServerProperties} to
25+
* {@link ShadedNettyGrpcServerFactory}.
2426
*
2527
* @author Chris Bono
2628
*/
27-
class ShadedNettyServerFactoryPropertyMapper extends BaseServerFactoryPropertyMapper<NettyServerBuilder> {
29+
class ShadedNettyServerFactoryPropertyMapper extends DefaultServerFactoryPropertyMapper<NettyServerBuilder> {
2830

2931
ShadedNettyServerFactoryPropertyMapper(GrpcServerProperties properties) {
3032
super(properties);

spring-grpc-spring-boot-autoconfigure/src/test/java/org/springframework/grpc/autoconfigure/server/ServerFactoryPropertyMappersTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import static org.mockito.Mockito.mock;
2929

3030
/**
31-
* Tests for {@link BaseServerFactoryPropertyMapper},
31+
* Tests for {@link DefaultServerFactoryPropertyMapper},
3232
* {@link NettyServerFactoryPropertyMapper}, and
3333
* {@link ShadedNettyServerFactoryPropertyMapper}.
3434
*
@@ -51,10 +51,10 @@ void customizeNettyServerBuilder() {
5151
@Test
5252
<T extends ServerBuilder<T>> void customizeBaseServerBuilder() {
5353
T builder = mock();
54-
customizeServerBuilder(BaseServerFactoryPropertyMapper::new, () -> builder);
54+
customizeServerBuilder(DefaultServerFactoryPropertyMapper::new, () -> builder);
5555
}
5656

57-
private <T extends ServerBuilder<T>, X extends BaseServerFactoryPropertyMapper<T>> void customizeServerBuilder(
57+
private <T extends ServerBuilder<T>, X extends DefaultServerFactoryPropertyMapper<T>> void customizeServerBuilder(
5858
Function<GrpcServerProperties, X> mapperFactory, Supplier<T> mockBuilderToCustomize) {
5959
GrpcServerProperties properties = new GrpcServerProperties();
6060
properties.getKeepAlive().setTime(Duration.ofHours(1));

0 commit comments

Comments
 (0)