Generate config props docs#25
Merged
dsyer merged 1 commit intospring-projects:mainfrom Oct 8, 2024
Merged
Conversation
onobc
commented
Oct 7, 2024
| @@ -0,0 +1,18 @@ | |||
| |=== | |||
Contributor
Author
There was a problem hiding this comment.
This file is automatically generated. Should we even check it in? I notice other spring-cloud repos are checking it in. I believe having it checked in avoids annoying red warnings coming from the consuming adocs that are referencing it.
onobc
commented
Oct 7, 2024
| /** | ||
| * Generate Asciidoc for configuration properties. | ||
| * <p> | ||
| * Copied from 'spring-cloud-build' to avoid direct dependency on Spring Cloud. |
Contributor
Author
There was a problem hiding this comment.
I did not want to put a direct dependency on spring-cloud-build just for this. I therefore copy/pasta shift/lift etc..
I will take a pass through this code in a subsequent PR as it can be simplified greatly and get a little 2024 makeover.
Member
|
Might need to be rebased and force pushed your end? |
onobc
force-pushed
the
generate-config-props-docs
branch
from
a8010d6 to
eae26b0
Compare
Contributor
Author
Should be good now @dsyer . Thanks. |
onobc
force-pushed
the
generate-config-props-docs
branch
from
eae26b0 to
b40fa3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Review after #24 as this PR is built on top of the 2 commits in #24
This adds automatic config props document generation.
