Polishing.

Remove MethodParameter.initParameterNameDiscovery(…) calls using DefaultParameterNameDiscoverer as MethodParameter uses the shared DefaultParameterNameDiscoverer instance already.

See #3431
Original pull request: #3432

Author: mp911de

src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java

@@ -32,7 +32,6 @@
 
 import org.springframework.core.DefaultParameterNameDiscoverer;
 import org.springframework.core.KotlinDetector;
-import org.springframework.core.ParameterNameDiscoverer;
 import org.springframework.core.annotation.MergedAnnotations;
 import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.core.TypeInformation;

src/main/java/org/springframework/data/mapping/model/PreferredConstructorDiscoverer.java

@@ -32,7 +32,6 @@
 
 import org.springframework.core.DefaultParameterNameDiscoverer;
 import org.springframework.core.KotlinDetector;
-import org.springframework.core.ParameterNameDiscoverer;
 import org.springframework.core.annotation.AnnotationUtils;
 import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.core.TypeInformation;

src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryBeanDefinitionPropertiesDecorator.java

@@ -26,7 +26,6 @@
 
 import org.springframework.beans.factory.BeanFactory;
 import org.springframework.beans.factory.config.BeanDefinition;
-import org.springframework.core.DefaultParameterNameDiscoverer;
 import org.springframework.core.MethodParameter;
 import org.springframework.core.ResolvableType;
 import org.springframework.data.repository.aot.generate.AotRepositoryFragmentMetadata.ConstructorArgument;
@@ -102,8 +101,6 @@ public CodeBlock decorate() {
 			for (int i = 0; i < it.getParameterCount(); i++) {
 
 				MethodParameter parameter = new MethodParameter(it, i);
-				parameter.initParameterNameDiscovery(DefaultParameterNameDiscoverer.getSharedInstance());
-
 				callbackMethod.addParameter(parameter.getParameterType(), parameter.getParameterName());
 			}
 

src/main/java/org/springframework/data/repository/aot/generate/MethodMetadata.java

@@ -27,9 +27,7 @@
 
 import org.jspecify.annotations.Nullable;
 
-import org.springframework.core.DefaultParameterNameDiscoverer;
 import org.springframework.core.MethodParameter;
-import org.springframework.core.ParameterNameDiscoverer;
 import org.springframework.core.ResolvableType;
 import org.springframework.data.core.TypeInformation;
 import org.springframework.data.javapoet.TypeNames;
@@ -64,7 +62,7 @@ class MethodMetadata {
 
 		ResolvableType repositoryInterface = ResolvableType.forClass(repositoryInformation.getRepositoryInterface());
 
-		initializeMethodArguments(method, DefaultParameterNameDiscoverer.getSharedInstance(), repositoryInterface, methodArguments, methodParameters);
+		initializeMethodArguments(method, repositoryInterface, methodArguments, methodParameters);
 
 		this.methodArguments = Collections.unmodifiableMap(methodArguments);
 		this.methodParameters = Collections.unmodifiableMap(methodParameters);
@@ -75,7 +73,7 @@ static ResolvableType resolvePrimaryIfNecessary(TypeInformation<?> type) {
 				: type.toResolvableType();
 	}
 
-	private static void initializeMethodArguments(Method method, ParameterNameDiscoverer nameDiscoverer,
+	private static void initializeMethodArguments(Method method,
 			ResolvableType repositoryInterface, Map<String, ParameterSpec> methodArguments,
 			Map<String, MethodParameter> methodParameters) {
 
@@ -85,7 +83,6 @@ private static void initializeMethodArguments(Method method, ParameterNameDiscov
 
 			MethodParameter methodParameter = MethodParameter.forParameter(parameter)
 					.withContainingClass(repositoryInterfaceType);
-			methodParameter.initParameterNameDiscovery(nameDiscoverer);
 
 			TypeName parameterType = parameterTypeName(methodParameter, repositoryInterfaceType);
 

src/main/java/org/springframework/data/repository/support/MethodParameters.java

@@ -24,9 +24,7 @@
 
 import org.jspecify.annotations.Nullable;
 
-import org.springframework.core.DefaultParameterNameDiscoverer;
 import org.springframework.core.MethodParameter;
-import org.springframework.core.ParameterNameDiscoverer;
 import org.springframework.data.util.Lazy;
 import org.springframework.util.Assert;
 
@@ -65,7 +63,6 @@ public MethodParameters(Method method, Optional<AnnotationAttribute> namingAnnot
 		for (int i = 0; i < method.getParameterCount(); i++) {
 
 			MethodParameter parameter = new AnnotationNamingMethodParameter(method, i, namingAnnotation);
-			parameter.initParameterNameDiscovery(DefaultParameterNameDiscoverer.getSharedInstance());
 			parameters.add(parameter);
 		}
 	}

src/main/java/org/springframework/data/util/NullnessMethodInvocationValidator.java

@@ -28,11 +28,9 @@
 import org.jspecify.annotations.NullMarked;
 import org.jspecify.annotations.Nullable;
 
-import org.springframework.core.DefaultParameterNameDiscoverer;
 import org.springframework.core.KotlinDetector;
 import org.springframework.core.MethodParameter;
 import org.springframework.core.Nullness;
-import org.springframework.core.ParameterNameDiscoverer;
 import org.springframework.util.ClassUtils;
 import org.springframework.util.ObjectUtils;
 
@@ -78,7 +76,7 @@ public static boolean supports(Class<?> type) {
 
 		if (nullness == null) {
 
-			nullness = MethodNullness.of(method, DefaultParameterNameDiscoverer.getSharedInstance());
+			nullness = MethodNullness.of(method);
 			nullabilityCache.put(method, nullness);
 		}
 
@@ -140,7 +138,7 @@ private MethodNullness(boolean nullableReturn, boolean[] nullableParameters, Met
 			this.methodParameters = methodParameters;
 		}
 
-		static MethodNullness of(Method method, ParameterNameDiscoverer discoverer) {
+		static MethodNullness of(Method method) {
 
 			boolean nullableReturn = isNullableParameter(new MethodParameter(method, -1));
 			boolean[] nullableParameters = new boolean[method.getParameterCount()];
@@ -149,7 +147,6 @@ static MethodNullness of(Method method, ParameterNameDiscoverer discoverer) {
 			for (int i = 0; i < method.getParameterCount(); i++) {
 
 				MethodParameter parameter = new MethodParameter(method, i);
-				parameter.initParameterNameDiscovery(discoverer);
 				nullableParameters[i] = isNullableParameter(parameter);
 				methodParameters[i] = parameter;
 			}

src/test/kotlin/org/springframework/data/repository/query/KParameterUnitTests.kt

@@ -17,7 +17,6 @@ package org.springframework.data.repository.query
 
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.jupiter.api.Test
-import org.springframework.core.DefaultParameterNameDiscoverer
 import org.springframework.core.MethodParameter
 import org.springframework.data.core.TypeInformation
 import kotlin.reflect.jvm.javaMethod
@@ -34,7 +33,6 @@ class KParameterUnitTests {
 
         val methodParameter =
             MethodParameter(MyCoroutineRepository::hello.javaMethod!!, 0)
-        methodParameter.initParameterNameDiscovery(DefaultParameterNameDiscoverer())
 		val parameter = Parameter(methodParameter, TypeInformation.OBJECT)
 
         assertThat(parameter.name).isEmpty()