Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer #3058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer #3058

wants to merge 1 commit into from
+1 −0

Conversation

kimjinmyeong
Copy link

@kimjinmyeong kimjinmyeong commented Nov 26, 2024 •
edited
Loading

The useForType method in GenericJackson2JsonRedisSerializer overrides DefaultTypeResolverBuilder.useForType but was missing the @Override annotation.
so I added @Override to useForType in GenericJackson2JsonRedisSerializer.

(Since this is a minor change that only adds an annotation, I did not add myself as an author in the class header... but, if it is considered necessary, I am happy to update the PR.)

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@kimjinmyeong
Fix: Add missing @OverRide annotation to useForType
0881363 
This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 26, 2024
@kimjinmyeong kimjinmyeong changed the title Fix: Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Nov 26, 2024
@kimjinmyeong kimjinmyeong changed the title Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing @Override annotation in GenericJackson2JsonRedisSerializer
2 participants
@kimjinmyeong @spring-projects-issues