Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable Project-wise search in "Search files by name" [Feature request] #22461

Open
OverLordGoldDragon opened this issue Sep 7, 2024 · 9 comments

Comments

@OverLordGoldDragon
Copy link
Contributor

The feature is significantly slower in Spyder 6.0.0, I assume because it also includes Project files in search. I use this feature extensively, and high responsiveness is quite important to me. Can legacy behavior be provided as an option? I'd appreciate that.

@OverLordGoldDragon OverLordGoldDragon changed the title Option to disable Project-wise search in "Search files by name" Option to disable Project-wise search in "Search files by name" [Feature request] Sep 7, 2024
@dalthviz
Copy link
Member

dalthviz commented Nov 6, 2024

Hi @OverLordGoldDragon thank you for the feedback and sorry for the late response! Related with slowness when having a project activated maybe these issues could be related: #22567 and #22556 . Particulary #22556 (comment) describes a way to patch your local Spyder installation to prevent using either fzf (which allows for searching project files) or disabling the file watcher which could help improve the responsiveness of the search.

Anyhow, what do you think @spyder-ide/core-developers ?

@ccordoba12
Copy link
Member

If fzf is not working as expected under some scenarios, we need to provide an option for users to disable it.

Leaving this for 6.1.0 because it requires a new entry in Preferences for the Projects plugin.

@ccordoba12
Copy link
Member

By the way @dalthviz, how does our fzf support work for you on Windows? For me it works really well on Linux.

@dalthviz
Copy link
Member

dalthviz commented Nov 7, 2024

I don't use much the switcher functionality to be honest but doing a quick check this is what I'm experiencing:

switcher_fzf

@ccordoba12
Copy link
Member

Thanks for checking @dalthviz! It works pretty much the same for me, so perhaps the problem has to do with too many files (more than 10k?) in the current project directory.

@dalthviz
Copy link
Member

dalthviz commented Nov 8, 2024

perhaps the problem has to do with too many files (more than 10k?) in the current project directory.

Maybe, do you experience a worst performance than the one shown in the GIFs above @OverLordGoldDragon ? Are you by any chance working on a project with many files?

Nonetheless, thinking this a little more. having an option to enable or disable fzf usage makes sense to me 👍

@OverLordGoldDragon
Copy link
Contributor Author

OverLordGoldDragon commented Nov 9, 2024

It's about on par, from what I recall. As for files, 1.4k in total, of which 100 are py files, and 1.1k are in .git/ (almost entirely in .git/objects). Here's a WinDirStat

@ccordoba12
Copy link
Member

@OverLordGoldDragon, so why do you prefer to turn off this feature?

@OverLordGoldDragon
Copy link
Contributor Author

Well, it's very slow. Spyder 5 is nearly instant, this is 500-1000ms. I also prefer keeping the search to .py files, as I use Spyder almost exclusively for .py, though that's not as important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants