refresh() method does not honors should_cache_fn function

[sqlalchemy-bot]

Migrated issue, originally created by Anonymous

CacheRegion.cache_on_arguments() has a parameter should_cache_fn which is used to control if content should be cached or not. the .refresh() method on the decorated function ignores it and goes directly to the backend.set()

[sqlalchemy-bot]

Michael Bayer (zzzeek) wrote:

refresh probably should consult should_cache_fn (whereas set() should not?) , however I'm not comfortable w/ backwards incompatible behavior here. I'd rather clarify documentation and add .conditional_refresh().

[sqlalchemy-bot]

Michael Bayer (zzzeek) wrote:

Here's a sketch of a patch: https://gerrit.sqlalchemy.org/269 it would be helpful if someone could take the time to contribute tests.