Order type and sources should be cleaned up

[godsgood33]

Describe the bug
The order sources and tender types are confusing and difficult to code for.

Expected behavior
Clean and concise order sources and tender types

To Reproduce
Steps to reproduce the bug:

1. Retrieve order that was processed as house account or invoice

Square SDK version
25.2.0.20230315

Additional context
Order tenders that are rung up with a "house account" display in the API as "OTHER". This should be changed to "HOUSE_ACCOUNT". When an invoice is created it too displays in the API tender type as "OTHER" and the order source is blank. When pulling from the deprecated transaction API on the API explorer the product displays "INVOICES", but that is not in the orders API. The order source should be changed to "INOVICE" and the tender type should be whatever tender was used to pay for the order "CARD", "CHECK", "ACH", etc. I'm pretty sure this affects the entire API and not just the PHP SDK, but I don't see the main API listed as publicly available.

[zenmasterjobo]

Hi @godsgood33

You are correct in suggesting that this issue is at the API level, and not the SDK level. In the future when having questions about developing with square / improvements to the platform or if you run into other development issues, the best place to post questions is on our Developer Forums as this forum is monitored by Square employees, and you will get a response within 48 hours.

I have gone ahead and relayed this information to our API team and will let you know any updates!

Thank you 🙏

[godsgood33]

@zenmasterjobo Thanks! I wasn't sure where to go to post a bug with the API. I will save that link and use it in the future.

[zenmasterjobo]

Hi @godsgood33,

Just wanted to update that this issue is indeed already on the API team's radar, and they are looking to address this issue. I don't have much more update than that at this time unfortunately, but will come back to update here when I learn anything more.

Thanks again for calling this out!

[godsgood33]

Thanks for the update.