Skip to content

Commit abd1992

Browse files
committed
check for default type
1 parent d0ca311 commit abd1992

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

lib/Serializer.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace SR\Serializer;
1313

1414
use SR\Serializer\Type\SerializerTypeInterface;
15+
use SR\Serializer\Type\SerializerTypePhp;
1516

1617
class Serializer implements SerializerInterface
1718
{
@@ -107,9 +108,9 @@ final public function getSerializer() : SerializerTypeInterface
107108
/**
108109
* @return bool
109110
*/
110-
final public function hasSerializer() : bool
111+
final public function hasDefaultSerializer() : bool
111112
{
112-
return static::$serializer instanceof SerializerTypeInterface;
113+
return static::$serializer instanceof SerializerTypePhp && static::$serializer->supported();
113114
}
114115

115116
/**

lib/SerializerInterface.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,5 @@ public function getSerializer() : SerializerTypeInterface;
8181
/**
8282
* @return bool
8383
*/
84-
public function hasSerializer() : bool;
84+
public function hasDefaultSerializer() : bool;
8585
}

tests/SerializerFactoryTest.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,11 @@ public function testNotSupported()
157157
$serializer = Serializer::create(SerializerTypeNotSupported::class);
158158

159159
$this->assertInstanceOf(SerializerInterface::class, $serializer);
160-
$this->assertFalse($serializer->hasSerializer());
160+
$this->assertTrue($serializer->hasDefaultSerializer());
161+
162+
$serializer = Serializer::create();
163+
164+
$this->assertFalse($serializer->hasDefaultSerializer());
161165
}
162166
}
163167

0 commit comments

Comments
 (0)