Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dualshock 4 button prompts not shown #18

Open
r3vert opened this issue May 14, 2024 · 7 comments
Open

Dualshock 4 button prompts not shown #18

r3vert opened this issue May 14, 2024 · 7 comments

Comments

@r3vert
Copy link

r3vert commented May 14, 2024

I just started using this theme, while it is very good, one issue I noticed is that when using an external dualshock controller, the button prompts are empty. When unplugging the external controller, the native button prompts show as normal.

With dualshock 4
Screenshot 2024-05-13 222402
No external controller (defaults to steam deck controller icons)
Screenshot 2024-05-13 222507

@r3vert
Copy link
Author

r3vert commented May 14, 2024

i have inspected the ccs for the button prompts and have determined that the filter (--srcery-bright-white-filter) that colors the steam deck buttons is overshadowing the playstation equivalents

Playstation controller with filter applied (not showing)
Screenshot 2024-05-13 225235
Playstation controller with filter removed manually (working but not tinted
Screenshot 2024-05-13 225242

@r3vert
Copy link
Author

r3vert commented May 14, 2024

this seems to just be an issue with the images steam uses for the playstation face buttons as the l1 and r1 buttons work just fine. I assume this is because the playstation buttons do not have transparency like the steam deck buttons do
playstation button (colored, non-transparent)
ps_color_button_circle
playstation L1 and steam button (work just fine, text is cut out)
shared_button_x
ps4_l1

@r3vert
Copy link
Author

r3vert commented May 14, 2024

I have found a solution to this issue, by using the "White Xbox Button" plugin, we can set the buttons to be the same style as the steam deck buttons, making the coloring appear correct
Screenshot 2024-05-14 111031

@milogert
Copy link
Member

Hey, thanks for the feedback. Unfortunately I don't have a DualShock 4 Controller to test this with. If you were able to open a PR that fixes this it would be welcome!

@r3vert
Copy link
Author

r3vert commented May 16, 2024

should I also add new options in the theme manager to switch to the blank or original colored buttons?

@r3vert
Copy link
Author

r3vert commented May 16, 2024

I have just finished fixing the issue, i'll try to make a pull request

@milogert
Copy link
Member

Hey thanks for working on this. Things have been really busy around here. I don't think you need an option. Someone setting the theme probably just expects the buttons to be colored in a specific way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants