Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the e2e.yml workflows run only if rust.yml workflows pass #119

Open
srdtrk opened this issue Jun 18, 2024 · 1 comment · Fixed by #120
Open

Have the e2e.yml workflows run only if rust.yml workflows pass #119

srdtrk opened this issue Jun 18, 2024 · 1 comment · Fixed by #120
Labels
e2e Concerning end to end tests good first issue Good for newcomers

Comments

@srdtrk
Copy link
Owner

srdtrk commented Jun 18, 2024

It seems that already we have too many runners to run them in parallel. It's also a waste to run e2e's if rust.yml is failing. We might also wanna add a job (in rust.yml) to see if testing contracts build. Since a common reason for e2e's to fail is forgetting to run cargo update on testing contracts

@srdtrk
Copy link
Owner Author

srdtrk commented Jun 18, 2024

Reopening since the previous PR doesn't address the issue and is now reverted

@srdtrk srdtrk reopened this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Concerning end to end tests good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant