Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot use Unicode in filename #419

Closed
linusboyle opened this issue Oct 1, 2020 · 5 comments · Fixed by #424
Closed

cannot use Unicode in filename #419

linusboyle opened this issue Oct 1, 2020 · 5 comments · Fixed by #424
Assignees
Labels
bug Something isn't working
Milestone

Comments

@linusboyle
Copy link

To reproduce, simply create a zettel named 计算机.md (the content does not matter), and link to it in another zettel by [[计算机]]. neuron then complains that links to non-existant zettel: 计算机

I think languages with wide characters should all have this problem.

@linusboyle
Copy link
Author

If I use the markdown builtin syntax, neuron does not give error. But when I click the link it says File not found.

@srid
Copy link
Owner

srid commented Oct 1, 2020

Did you create the zettel using neuron new? If so, it is possibly the same as #381 - and you would want to try creating the file manually (eg: echo Hello > 计算机.md) to see if the problem goes away.

(FWIW, this doesn't happen in Cerveau).

@linusboyle
Copy link
Author

Did you create the zettel using neuron new?

No, I created it manually. The problem is not that neuron-cli would mess up the content of the file, but that the note with unicode in its filename is not even recognized by neuron. It's not in any search or query result, and the generated site does not contain it.

PS: I tried Piemērs as in #381 and it's the same, so this happens to any unicode.

@linusboyle linusboyle changed the title cannot use CJK character as title ID cannot use Unicode in filename Oct 2, 2020
@srid
Copy link
Owner

srid commented Oct 2, 2020

I see a different error here:

image

@srid
Copy link
Owner

srid commented Oct 2, 2020

Okay so - modern-uri, which is used to parse the content inside wiki-links, is unable to deal with unicode:

image

@srid srid added help wanted Extra attention is needed hacktoberfest labels Oct 2, 2020
@srid srid added this to the 1.0 milestone Oct 7, 2020
@srid srid self-assigned this Oct 7, 2020
@srid srid pinned this issue Oct 7, 2020
@srid srid added bug Something isn't working and removed hacktoberfest help wanted Extra attention is needed labels Oct 7, 2020
@srid srid closed this as completed in #424 Oct 7, 2020
@srid srid unpinned this issue Oct 8, 2020
srid added a commit that referenced this issue May 6, 2021
Normalize unicode filenames to NFC

Ref:
- #611
- #419

Resolves #611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants