Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode file-named notes are being ignored #636

Closed
fz68 opened this issue Jul 15, 2021 · 10 comments
Closed

Unicode file-named notes are being ignored #636

fz68 opened this issue Jul 15, 2021 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@fz68
Copy link

fz68 commented Jul 15, 2021

run neuron gen --pretty-urls locally on my Mac is OK.
But check github's action info, show some notes missing, only ascii named notes remain and generate htmls.

@srid
Copy link
Owner

srid commented Jul 15, 2021

Hmm,

So this happens only when using Docker? Wonder what the issue with Docker is ...

@fz68
Copy link
Author

fz68 commented Jul 20, 2021

Tried neuron on clean installed ubuntu 20.04 ARM64, same problem.
截屏2021-07-20 12 01 39

@srid
Copy link
Owner

srid commented Jul 20, 2021

@FanZhen2002 Does setting the LANG environment variable as suggested here resolve it?

@srid srid changed the title When use docker to publish, some unicode named notes are missing Unicode file-named notes are being ignored Jul 20, 2021
@fz68
Copy link
Author

fz68 commented Jul 22, 2021

@FanZhen2002 Does setting the LANG environment variable as suggested here resolve it?
It works.
LOCALE_ARCHIVE=/usr/lib/locale/locale-archive neuron gen --pretty-urls

@srid
Copy link
Owner

srid commented Jul 22, 2021

Great; I suppose we can modify the docker workflow to use this environment variable, then.

@fz68
Copy link
Author

fz68 commented Jul 22, 2021

No luck
https://github.com/FanZhen2002/zk/runs/3130704294#step:3:13
with
docker run --env LOCALE_ARCHIVE=/usr/lib/locale/locale-archive -v $PWD:/notes sridca/neuron neuron gen --pretty-urls

@srid
Copy link
Owner

srid commented Jul 22, 2021

When you wrote "It works" in https://github.com/srid/neuron-template/issues/10#issuecomment-884600194 - where did it work?

@srid srid transferred this issue from srid/neuron-template Jul 22, 2021
@srid
Copy link
Owner

srid commented Jul 22, 2021

Okay, I have a fix for this (based on #381), and it will go in the Docker image. I'll close this issue once that happens.

@srid srid self-assigned this Jul 22, 2021
@srid srid added the bug Something isn't working label Jul 22, 2021
srid added a commit that referenced this issue Jul 22, 2021
@srid
Copy link
Owner

srid commented Jul 22, 2021

@FanZhen2002 Fix pushed. Let me know if that resolves it.

@srid
Copy link
Owner

srid commented Jul 23, 2021

Fix confirmed, http://zk.fanzhen.org/impulse

@srid srid closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants