fix: don't re-fire the same Splitwise notification event every poll

The splitwise library's getNotifications() accepts updated_since/limit
params but never actually applies them (unimplemented upstream) - every
poll re-fetches the same "recent notifications" window regardless of
what was already seen. Without dedup, the same notification would fire
its splitwise_notification_event_* bus event again every SCAN_INTERVAL
for as long as it stayed in that window, not just once when it appeared.

Track notification ids seen on the previous poll and only fire events
for ones not seen before. Note: this is in-memory only, so a HA restart
still causes one re-fire of whatever's currently in the recent window.

Author: sriramsv

custom_components/splitwise/coordinator.py

@@ -70,6 +70,12 @@ def __init__(
         self.entry = entry
         self.session = session
         self.client = client
+        # The splitwise library's getNotifications() ignores its own
+        # updated_since/limit params (unimplemented upstream), so every poll
+        # re-fetches the same "recent notifications" window. Track which ids
+        # we've already fired events for so we don't re-fire the same
+        # notification every SCAN_INTERVAL for as long as it stays recent.
+        self._seen_notification_ids: set[int] = set()
 
     def _fetch_splitwise_data(self, token):
         """Run on the executor: sync the token into the client and fetch data."""
@@ -190,7 +196,12 @@ async def _async_update_data(self) -> SplitwiseData:
         )
 
     def _emit_notifications(self, notifications):
-        for n in notifications:
+        current_ids = {n.getId() for n in notifications}
+        new_notifications = [
+            n for n in notifications if n.getId() not in self._seen_notification_ids
+        ]
+
+        for n in new_notifications:
             self.hass.bus.fire(
                 "splitwise_notification_event_" + str(n.getType()),
                 {
@@ -209,3 +220,5 @@ def _emit_notifications(self, notifications):
                 },
                 origin="REMOTE",
             )
+
+        self._seen_notification_ids = current_ids

custom_components/splitwise/manifest.json

@@ -8,5 +8,5 @@
     "iot_class": "cloud_polling",
     "issue_tracker": "https://github.com/sriramsv/custom_component_splitwise/issues",
     "requirements": ["splitwise==3.0.0"],
-    "version": "0.3.0"
+    "version": "0.3.1"
   }