Skip to content

Commit ced0ce2

Browse files
committed
fix: resolve HACS/hassfest CI validation failures
Fixes surfaced by the new validate.yml workflow's first run: - manifest.json: codeowners entries must be prefixed with "@" to be recognized as valid GitHub handles. - strings.json/translations/en.json: application_credentials.description contained a markdown link/raw URL, which hassfest's translation validator rejects; reworded to avoid it (full instructions remain in README, linked via manifest.json's documentation field). - __init__.py: added CONFIG_SCHEMA = cv.config_entry_only_config_schema to resolve hassfest's warning about integrations with async_setup lacking a config schema (this integration isn't configurable via a top-level "splitwise:" YAML key). - hacs.json: removed "domains" and "version" keys, which are no longer part of HACS's accepted schema (HACS derives version from GitHub releases, not this file); fixed "country" to be a string per schema. - custom_components/splitwise/brand/: replaced the icon.txt MDI fallback (an HA-core-only mechanism, not recognized by HACS's own brands check) with real icon.png (256x256) and icon@2x.png (512x512) placeholder images, satisfying HACS's brands validation. Swap these for the final custom-designed graphic later.
1 parent e8afed9 commit ced0ce2

8 files changed

Lines changed: 8 additions & 8 deletions

File tree

custom_components/splitwise/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import logging
66
from dataclasses import dataclass
77

8+
import homeassistant.helpers.config_validation as cv
89
from homeassistant.config_entries import ConfigEntry
910
from homeassistant.const import CONF_PLATFORM, Platform
1011
from homeassistant.core import HomeAssistant
@@ -16,6 +17,8 @@
1617

1718
_LOGGER = logging.getLogger(__name__)
1819

20+
CONFIG_SCHEMA = cv.config_entry_only_config_schema(DOMAIN)
21+
1922
PLATFORMS = [Platform.SENSOR]
2023

2124

2.06 KB
Loading

custom_components/splitwise/brand/icon.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.
4.61 KB
Loading

custom_components/splitwise/manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
"documentation": "https://github.com/sriramsv/custom_component_splitwise",
55
"issue_tracker": "https://github.com/sriramsv/custom_component_splitwise/issues",
66
"dependencies": ["application_credentials"],
7-
"codeowners": ["sriramsv"],
7+
"codeowners": ["@sriramsv"],
88
"requirements": ["splitwise==3.0.0"],
99
"iot_class": "cloud_polling",
1010
"config_flow": true,
11-
"version": "0.2.7"
11+
"version": "0.2.8"
1212
}

custom_components/splitwise/strings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
}
2626
},
2727
"application_credentials": {
28-
"description": "To link your Splitwise account, register an application at the [Splitwise Developer portal](https://secure.splitwise.com/apps). Set the Callback URL to `https://my.home-assistant.io/redirect/oauth`. Splitwise will give you a **Consumer Key** and **Consumer Secret** — enter the Consumer Key in the Client ID field below, and the Consumer Secret in the Client Secret field."
28+
"description": "To link your Splitwise account, register an application in the Splitwise Developer portal (see the integration documentation for the exact Callback URL to use). Splitwise will give you a Consumer Key and a Consumer Secret: enter the Consumer Key in the Client ID field below, and the Consumer Secret in the Client Secret field."
2929
},
3030
"issues": {
3131
"deprecated_yaml": {

custom_components/splitwise/translations/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
}
2626
},
2727
"application_credentials": {
28-
"description": "To link your Splitwise account, register an application at the [Splitwise Developer portal](https://secure.splitwise.com/apps). Set the Callback URL to `https://my.home-assistant.io/redirect/oauth`. Splitwise will give you a **Consumer Key** and **Consumer Secret** — enter the Consumer Key in the Client ID field below, and the Consumer Secret in the Client Secret field."
28+
"description": "To link your Splitwise account, register an application in the Splitwise Developer portal (see the integration documentation for the exact Callback URL to use). Splitwise will give you a Consumer Key and a Consumer Secret: enter the Consumer Key in the Client ID field below, and the Consumer Secret in the Client Secret field."
2929
},
3030
"issues": {
3131
"deprecated_yaml": {

hacs.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
{
22
"name": "Splitwise Sensor",
3-
"domains": ["sensor"],
4-
"country": ["US"],
5-
"version": "0.2.7",
3+
"country": "US",
64
"render_readme": true
75
}

0 commit comments

Comments
 (0)