core/config: Add Git variables to lab topology names #2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
- Coverage 55.50% 55.46% -0.04%
==========================================
Files 218 218
Lines 21561 21596 +35
==========================================
+ Hits 11967 11978 +11
- Misses 8367 8391 +24
Partials 1227 1227
🚀 New features to boost your workflow:
|
hellt
reviewed
Nov 28, 2025
Comment on lines
+44
to
+46
| // clab name specific variables | ||
| gitBranchVar = "__gitBranch__" | ||
| gitHashVar = "__gitHash__" |
Member
There was a problem hiding this comment.
I think it would make sense to record the branch and hash as node labels as well
Contributor
Author
There was a problem hiding this comment.
I'll add this and move the PR to a ready to review state once I have some free time - hopefully soon.
hellt
reviewed
Nov 28, 2025
| ) | ||
| } | ||
|
|
||
| // magicVarReplacer returns a string replacer that replaces all supported magic variables. |
Member
There was a problem hiding this comment.
looks like the comment needs to be adjusted to only mention specific variables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick proof-of-concept code I whipepd up on a long train ride based on #2949.
Works similarly as the magic node name variables that can get substituted in, except for the topology name. I have done some cursory testing, but didn't want to over-commit on that before I get some feedback on the overall idea.
This could help with use-cases involving Containerlab in multi-tenant labs and CI/CD environments, where the runner isn't a temporary environment.