chore(ci): unify local and CI checks under make verify

Author: srmdn

.github/workflows/ci.yml

@@ -23,17 +23,5 @@ jobs:
           go-version-file: go.mod
           cache: true
 
-      - name: Format check
-        run: |
-          unformatted="$(gofmt -l .)"
-          if [ -n "$unformatted" ]; then
-            echo "Unformatted files:"
-            echo "$unformatted"
-            exit 1
-          fi
-
-      - name: Build
-        run: go build ./...
-
-      - name: Test
-        run: go test ./...
+      - name: Verify
+        run: make verify

CONTRIBUTING.md

@@ -46,6 +46,18 @@ Cleanup runbook: [docs/AI-COMMIT-CLEANUP.md](docs/AI-COMMIT-CLEANUP.md)
 
 ## Development Expectations
 
+Before opening or updating a PR, run:
+
+```sh
+make verify
+```
+
+`make verify` runs:
+- formatting check (`gofmt -l .`)
+- build (`go build ./...`)
+- tests (`go test ./...`)
+- commit attribution check (`scripts/check-commit-attribution.sh`)
+
 Before requesting review for mail flow changes:
 - test success path and failure path
 - verify retry behavior and max retry boundaries

Makefile

@@ -1,7 +1,7 @@
 APP_NAME=maild
 MAIN_PACKAGE=./cmd/server
 
-.PHONY: setup run build test tidy
+.PHONY: setup run build test tidy fmt-check check-attribution verify
 
 setup:
 	@if [ ! -f .env ]; then cp .env.example .env; fi
@@ -20,3 +20,16 @@ test:
 
 tidy:
 	go mod tidy
+
+fmt-check:
+	@unformatted="$$(gofmt -l .)"; \
+	if [ -n "$$unformatted" ]; then \
+		echo "Unformatted files:"; \
+		echo "$$unformatted"; \
+		exit 1; \
+	fi
+
+check-attribution:
+	./scripts/check-commit-attribution.sh
+
+verify: fmt-check build test check-attribution

internal/service/message_service_safety_test.go

@@ -88,10 +88,10 @@ func (q *safetyQueue) Dequeue(context.Context, time.Duration) (int64, bool, erro
 }
 
 type safetyStore struct {
-	suppressed     bool
-	unsubscribed   bool
-	messagesByID   map[int64]domain.Message
-	nextMessageID  int64
+	suppressed      bool
+	unsubscribed    bool
+	messagesByID    map[int64]domain.Message
+	nextMessageID   int64
 	transitionCalls int
 }
 
@@ -158,7 +158,9 @@ func (s *safetyStore) ListMessages(context.Context, int64, int, time.Time, time.
 func (s *safetyStore) CountMessagesSince(context.Context, int64, string, time.Time) (int64, error) {
 	return 0, nil
 }
-func (s *safetyStore) UpsertWorkspacePolicy(context.Context, domain.WorkspacePolicy) error { return nil }
+func (s *safetyStore) UpsertWorkspacePolicy(context.Context, domain.WorkspacePolicy) error {
+	return nil
+}
 func (s *safetyStore) GetWorkspacePolicy(context.Context, int64) (domain.WorkspacePolicy, bool, error) {
 	return domain.WorkspacePolicy{}, false, nil
 }
@@ -184,4 +186,3 @@ func (s *safetyStore) ListWebhookDeadLettersByID(context.Context, int64, []int64
 func (s *safetyStore) UpdateWebhookEventReplayResult(context.Context, int64, string, int, string) error {
 	return nil
 }
-