Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ROS2 and/or dashing-devel branch for ROS2 #73

Open
klintan opened this issue Aug 16, 2019 · 4 comments
Open

Create ROS2 and/or dashing-devel branch for ROS2 #73

klintan opened this issue Aug 16, 2019 · 4 comments

Comments

@klintan
Copy link

klintan commented Aug 16, 2019

Hey, I'm converting the library to ROS2 Dashing, so it would be awesome if you could create a ROS2 or perhaps dashing-devel branch for this so that I can create a PR to that branch.

Many thanks!

@klintan
Copy link
Author

klintan commented Aug 25, 2019

Now compiles here: https://github.com/klintan/viso2

As soon as you have a branch created I'll create a PR for a thorough review.

@klintan
Copy link
Author

klintan commented Sep 14, 2019

Gentle bump here, it works now I would love to have a review of it, and I think there are others out there that would benefit of a ROS2 port.

@klintan
Copy link
Author

klintan commented Oct 6, 2019

@miquelmassot are there any maintainers on this project ?

@bomiquel
Copy link
Contributor

bomiquel commented Jul 18, 2023

Hey @klintan! First of all, sorry for the delay, there was no one assigned to the maintenance of this project. I'll try to keep it a bit more up to date.

I've created a dashing-devel branch so you can do a PR. I will be able to review your code when you do the PR, but for now I won't be able to test your modifications because I don't have access to a computer with ROS2.

Please update your project with the latest changes before making the pull request.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants