Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should feed-type-assuming methods be deprecated? #35

Open
christianbundy opened this issue Sep 30, 2019 · 1 comment
Open

How should feed-type-assuming methods be deprecated? #35

christianbundy opened this issue Sep 30, 2019 · 1 comment
Assignees

Comments

@christianbundy
Copy link
Contributor

This module contains a handful of methods that assume a feed type of ed25519, which won't be able to support other feed types. Should these be removed from the repo, or should we give the user the option to specify the feed type they want to use?

For example: getKeyFromAddress(addr): multiserver addresses only give a public key integer, but this method promises to return a feed type

See also: #34

@dominictarr
Copy link
Contributor

hmm, probably need to look at what uses this api. do those things really need a concept of a feed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants